Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish reconcile only after running trials are complete #861

Merged
merged 3 commits into from
Oct 9, 2019

Conversation

johnugeorge
Copy link
Member

@johnugeorge johnugeorge commented Oct 8, 2019

Experiment reconcile is set to complete only after running trials are complete


This change is Reviewable

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -176,7 +176,7 @@ func (r *ReconcileExperiment) Reconcile(request reconcile.Request) (reconcile.Re
}
instance := original.DeepCopy()

if instance.IsCompleted() {
if instance.IsCompleted() && !instance.HasRunningTrials() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

willn't this line make new trial never be created?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore my comment, get it now

@hougangliu
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 9, 2019
@hougangliu
Copy link
Member

/hold cancel

@hougangliu
Copy link
Member

/lgtm

@gaocegege
Copy link
Member

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants